mihaibudiu commented on code in PR #3733: URL: https://github.com/apache/calcite/pull/3733#discussion_r1624894858
########## babel/src/test/resources/sql/redshift.iq: ########## @@ -523,78 +523,78 @@ select deptno, ratio_to_report(sal) over (partition by deptno) from emp; !} # STDDEV_POP -select empno, stddev_pop(comm) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1; +select empno, stddev_pop(CAST(comm AS DECIMAL(12, 4))) over (order by empno rows unbounded preceding) from emp where deptno = 30 order by 1; Review Comment: I think that the current bug fix would solve both CALCITE-4924 and CALCITE-4871. The result type is correctly inferred, but the cast to decimal does nothing. I will take a look to see whether it would be easy to change the functions that compute STDDEV to use a higher precision internally. But that should probably be a separate PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
