XuQianJin-Stars commented on code in PR #3789:
URL: https://github.com/apache/calcite/pull/3789#discussion_r1663804340
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -2224,6 +2224,13 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
OperandTypes.NUMERIC_OPTIONAL_NUMERIC,
SqlFunctionCategory.NUMERIC);
+ /** The "LOG(numeric, numeric1)" function. Returns the base numeric1
logarithm of numeric. */
+ @LibraryOperator(libraries = {MYSQL, SPARK})
+ public static final SqlFunction LOG_MYSQL =
Review Comment:
> LOG_MYSQL means we use MYSQL mode. same as others name like
SUBSTR_POSTGRESQL. So I think LOG_MYSQL is good. Don't need to modifty it.
Here SUBSTR_POSTGRESQL will only use POSTGRESQL MODE, while the method
LOG_MYSQL here will be used by both lib modes, there is a difference here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
