kgyrtkirk commented on PR #3835: URL: https://github.com/apache/calcite/pull/3835#issuecomment-2211721901
> 1. Addressing range concerns, the CHAR to VARCHAR conversion is specific to IN conditions? the issue arised from the fact that `SqlToRel` had a different route to produce `=` checks when `IN` was rewritten to a set of OR conditions; this PR only makes that extra route go away - and shows the converter the full `=` expression to do the same conversion as it would have done in case it would have been part of the original query > 2. Is an update to simplifyAnd2ForUnknownAsFalse necessary, what scenarios would benefit from this change? not mandatory for the current bug ; as `1` solves that ; but I would rather restrict the cases in which `RexSimplify` could over-simplify things; as its a quite frequently called part. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
