kgyrtkirk commented on code in PR #3835:
URL: https://github.com/apache/calcite/pull/3835#discussion_r1667340518
##########
core/src/main/java/org/apache/calcite/sql2rel/SqlToRelConverter.java:
##########
@@ -1732,25 +1737,23 @@ public RelNode convertToSingleValueSubq(
} else {
comparisonOp = SqlStdOperatorTable.EQUALS;
}
+ RexNode rexComparison;
if (leftKeys.size() == 1) {
- rexComparison =
- rexBuilder.makeCall(comparisonOp,
- leftKeys.get(0),
- ensureSqlType(leftKeys.get(0).getType(),
- bb.convertExpression(rightVals)));
+ SqlCall sqlCall =
+ comparisonOp.createCall(rightVals.getParserPosition(),
leftKeys.get(0), rightVals);
+ rexComparison = bb.convertExpression(sqlCall);
} else {
assert rightVals instanceof SqlCall;
final SqlBasicCall call = (SqlBasicCall) rightVals;
assert (call.getOperator() instanceof SqlRowOperator)
&& call.operandCount() == leftKeys.size();
rexComparison =
- RexUtil.composeConjunction(rexBuilder,
- Util.transform(
- Pair.zip(leftKeys, call.getOperandList()),
- pair -> rexBuilder.makeCall(comparisonOp, pair.left,
- // TODO: remove requireNonNull when checkerframework
issue resolved
- ensureSqlType(requireNonNull(pair.left,
"pair.left").getType(),
- bb.convertExpression(pair.right)))));
+ RexUtil.composeConjunction(
Review Comment:
not really; this `conjunction` is there for complex expressions; which will
be there for `NOT IN` as well:
```
(a,b) NOT IN ((1,2), (3,4))
NOT ((a=1 && b=2) || (a=3 && b=4) )
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
