jduo commented on code in PR #3826:
URL: https://github.com/apache/calcite/pull/3826#discussion_r1669447264
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/EnumUtils.java:
##########
@@ -189,6 +233,15 @@ static Expression joinSelector(JoinRelType joinType,
PhysType physType,
expressions.add(expression);
}
}
+
+ if (generateCompactCode) {
Review Comment:
I've changed copy to generate the following code:
`new org.apache.calcite.linq4j.function.Function2() {
public String[] apply(org.apache.calcite.interpreter.Row left,
org.apache.calcite.interpreter.Row right) {
String[] outputArray = new String[201];
System.arraycopy(left.copyValues(), 0, outputArray, 0, 101);
System.arraycopy(right.copyValues(), 0, outputArray, 101, 100);
return outputArray;
}
public String[] apply(Object left, Object right) {
return apply(
(org.apache.calcite.interpreter.Row) left,
(org.apache.calcite.interpreter.Row) right);
}
}
`
I'll add that to the comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
