jduo commented on code in PR #3826:
URL: https://github.com/apache/calcite/pull/3826#discussion_r1672739862
##########
core/src/main/java/org/apache/calcite/interpreter/Row.java:
##########
@@ -86,6 +86,8 @@ public static Row of(@Nullable Object...values) {
}
/** Returns a copy of the values. */
+ // Note: This implements BuildInMethod.ROW_COPY_VALUES.
+ @SuppressWarnings("unused")
Review Comment:
I'm not sure if there's a guideline for this in Calcite.
In other projects I've seen this annotation used to mark methods that are
called via reflection or not used internally but needed in the public API to
prevent accidental removal due to refactoring. It also has the nice side-effect
of un-graying out in IDEs such as IntelliJ.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
