timgrein commented on code in PR #3855:
URL: https://github.com/apache/calcite/pull/3855#discussion_r1678943606


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -2595,7 +2595,7 @@ void checkModOperatorDivByZero(SqlOperatorFixture f) {
     }
     f.checkNull("1e1 / cast(null as float)");
 
-    f.checkScalarExact("100.1 / 0.00000000000000001", "DECIMAL(19, 0) NOT 
NULL",
+    f.checkScalarExact("100.1 / 0.00000000000000001", "DECIMAL(19, 19) NOT 
NULL",

Review Comment:
   I'll take a look, thanks for pointing it out. Do you've any guidance, which 
vendors/dbs one should try? (which do you usually try?) I guess some deviate 
more than others from the standard.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to