asolimando commented on code in PR #3855:
URL: https://github.com/apache/calcite/pull/3855#discussion_r1679003373
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -2595,7 +2595,7 @@ void checkModOperatorDivByZero(SqlOperatorFixture f) {
}
f.checkNull("1e1 / cast(null as float)");
- f.checkScalarExact("100.1 / 0.00000000000000001", "DECIMAL(19, 0) NOT
NULL",
+ f.checkScalarExact("100.1 / 0.00000000000000001", "DECIMAL(19, 19) NOT
NULL",
Review Comment:
Postgres is the most referenced one in discussions here around, but it's
generally a good practice to check SQL Server, Oracle, MySQL as well
(https://www.db-fiddle.com/ and https://sqlfiddle.com/ are a convenient way to
do so in general).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
