asolimando commented on code in PR #3858:
URL: https://github.com/apache/calcite/pull/3858#discussion_r1679421325
##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowAdapterTest.java:
##########
@@ -329,19 +329,10 @@ static void initializeArrowState(@TempDir Path
sharedTempDir) throws IOException
String sql = "select \"intField\", \"stringField\"\n"
+ "from arrowdata\n"
+ "where \"intField\" is null";
- String plan;
- if (Bug.CALCITE_6296_FIXED) {
- plan = "ArrowToEnumerableConverter\n"
+ String plan = "ArrowToEnumerableConverter\n"
Review Comment:
That test was already covering exactly this missing feature, and was meant
to be fixed upon implementing it.
I think it's OK unless you see the need of a new test around `IS NULL` which
is not covered here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
