asolimando commented on code in PR #3858:
URL: https://github.com/apache/calcite/pull/3858#discussion_r1679579911
##########
arrow/src/test/java/org/apache/calcite/adapter/arrow/ArrowAdapterTest.java:
##########
@@ -329,19 +329,10 @@ static void initializeArrowState(@TempDir Path
sharedTempDir) throws IOException
String sql = "select \"intField\", \"stringField\"\n"
+ "from arrowdata\n"
+ "where \"intField\" is null";
- String plan;
- if (Bug.CALCITE_6296_FIXED) {
- plan = "ArrowToEnumerableConverter\n"
+ String plan = "ArrowToEnumerableConverter\n"
Review Comment:
When you say it involves two Jira cases, you mean that it was added in a
past ticket and that we are modifying it in the context of this one?
The test has been originally inserted as disabled (per my request), I have
subsequently enabled it when the fallback on `Enumerable` was added, with the
guard on the present ticket exactly to have the test fixed as in this PR.
The value of the previous version of test was to exercise the fallback while
the feature wasn't supported, but now that part is not needed anymore and it
can be removed.
For clarity we can add a link to the present Jira ticket as it fully and
exclusively covers the feature, and the old tickets don't apply anymore.
Would that be OK for you, @caicancai?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
