caicancai commented on code in PR #3861:
URL: https://github.com/apache/calcite/pull/3861#discussion_r1680218943
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -788,6 +788,20 @@ final RelMetadataFixture sql(String sql) {
sql(sql).assertThatRowCount(is(1D), is(0D), is(1D));
}
+ @Test void testRowCountAggregateConstantKeysOnBigInput() {
Review Comment:
Add jira link
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -788,6 +788,20 @@ final RelMetadataFixture sql(String sql) {
sql(sql).assertThatRowCount(is(1D), is(0D), is(1D));
}
+ @Test void testRowCountAggregateConstantKeysOnBigInput() {
Review Comment:
+1
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdMaxRowCount.java:
##########
@@ -159,7 +159,7 @@ && allGroupKeysAreConstant(rel, predicateList)) {
return rowCount * rel.getGroupSets().size();
}
- private static boolean allGroupKeysAreConstant(Aggregate aggregate,
+ static boolean allGroupKeysAreConstant(Aggregate aggregate,
Review Comment:
protected or public might be better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
