rubenada commented on code in PR #3861:
URL: https://github.com/apache/calcite/pull/3861#discussion_r1680548040
##########
core/src/main/java/org/apache/calcite/rel/metadata/RelMdMaxRowCount.java:
##########
@@ -159,7 +159,7 @@ && allGroupKeysAreConstant(rel, predicateList)) {
return rowCount * rel.getGroupSets().size();
}
- private static boolean allGroupKeysAreConstant(Aggregate aggregate,
+ static boolean allGroupKeysAreConstant(Aggregate aggregate,
Review Comment:
We want to reuse this in RelMdRowCount, so I think it's better to have it
package-private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
