asolimando commented on code in PR #3858:
URL: https://github.com/apache/calcite/pull/3858#discussion_r1680588103
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -122,7 +122,13 @@ public Enumerable<Object> query(DataContext root,
ImmutableIntList fields,
treeNodes.add(
TreeBuilder.makeField(schema.getFields()
.get(schema.getFields().indexOf(schema.findField(data[0])))));
- treeNodes.add(makeLiteralNode(data[2], data[3]));
+
+ // if the split condition has more than two parts it's a binary
operator
+ // with an additional literal node
+ if (data.length > 2) {
+ treeNodes.add(makeLiteralNode(data[2], data[3]));
+ }
+
String equality = data[1];
Review Comment:
This is not necessarily an equality, right?
EDIT: It's not related to this PR, it's an overlook of the original one, but
let's take the chance to replace `equality` with `operator` here if you don't
mind, it's very confusing otherwise
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
