timgrein commented on code in PR #3858:
URL: https://github.com/apache/calcite/pull/3858#discussion_r1680815076
##########
arrow/src/main/java/org/apache/calcite/adapter/arrow/ArrowTable.java:
##########
@@ -122,7 +122,13 @@ public Enumerable<Object> query(DataContext root,
ImmutableIntList fields,
treeNodes.add(
TreeBuilder.makeField(schema.getFields()
.get(schema.getFields().indexOf(schema.findField(data[0])))));
- treeNodes.add(makeLiteralNode(data[2], data[3]));
+
+ // if the split condition has more than two parts it's a binary
operator
+ // with an additional literal node
+ if (data.length > 2) {
+ treeNodes.add(makeLiteralNode(data[2], data[3]));
+ }
+
String equality = data[1];
Review Comment:
Nope, it isn't. Gandiva refers to it as a function, but I think `operator`
definitely makes way more sense. Adjusted with [Rename equality to operator in
ArrowTable](https://github.com/apache/calcite/pull/3858/commits/a7c195b43cc0e7b1d6c84bcdd1873efebb3be0fb)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
