mihaibudiu commented on code in PR #3869:
URL: https://github.com/apache/calcite/pull/3869#discussion_r1685047337


##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -10857,6 +10857,7 @@ void assertSubFunReturns(boolean binary, String s, int 
start,
     f.checkFails("trim('' from 'abcde')",
         "Trim error: trim character must be exactly 1 character",
         true);
+    f.checkFails("trim()", "String to trim cannot be null", false);

Review Comment:
   Is this the expected error for this function?
   Or should the result be null?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to