mihaibudiu commented on code in PR #3869:
URL: https://github.com/apache/calcite/pull/3869#discussion_r1687098876
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlTrimFunction.java:
##########
@@ -130,6 +130,9 @@ public SqlTrimFunction(String name, SqlKind kind,
if (operands[1] == null) {
operands[1] = SqlLiteral.createCharString(" ", pos);
}
+ if (operands[2] == null) {
+ throw new IllegalArgumentException("String to trim cannot be null");
Review Comment:
"The second argument of trim cannot be null"
It's not clear what "string" you are referring to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
