normanj-bitquill commented on code in PR #3801:
URL: https://github.com/apache/calcite/pull/3801#discussion_r1687153303
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -630,6 +630,11 @@ public int regexpInstr(String value, String regex, int
position,
return matchIndex;
}
+ /** SQL {@code REGEXP_REPLACE} function with 2 arguments. */
+ public String regexpReplace(String s, String regex) {
+ return regexpReplace(s, regex, "", 1, 0, null);
Review Comment:
You are correct, there may be functional differences between the
implementation of `regexp_replace` here and what the engines actually have. I
would like to leave that out of scope for this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
