normanj-bitquill commented on code in PR #3801:
URL: https://github.com/apache/calcite/pull/3801#discussion_r1687172299
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlAbstractConformance.java:
##########
@@ -105,10 +105,6 @@ public abstract class SqlAbstractConformance implements
SqlConformance {
return SqlConformanceEnum.DEFAULT.isOffsetLimitAllowed();
}
- @Override public boolean isRegexReplaceCaptureGroupDollarIndexed() {
Review Comment:
There is a specific library function for BigQuery. BigQuery only supports
the 3 argument signature. BigQuery was the only engine that uses dollar signs
rather than backslash.
https://github.com/Bit-Quill/calcite/blob/calcite-6310-regex-replace/core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java#L642
https://github.com/Bit-Quill/calcite/blob/calcite-6310-regex-replace/core/src/main/java/org/apache/calcite/util/BuiltInMethod.java#L590
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
