suibianwanwank commented on code in PR #3929:
URL: https://github.com/apache/calcite/pull/3929#discussion_r1727272417
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7378,6 +7368,37 @@ static class ExtendedExpander extends Expander {
return super.visit(literal);
}
+ /**
+ * Add all possible expandable 'group by' expression to set, which is
+ * used to check whether expr could be expanded as alias or ordinal.
+ */
+ @RequiresNonNull({"root"})
+ private void addExpandableExpressions(@UnknownInitialization
ExtendedExpander this) {
+ switch (root.getKind()) {
+ case IDENTIFIER:
+ case LITERAL:
+ aliasOrdinalExpandSet.add(root);
+ break;
+ case GROUPING_SETS:
+ case ROLLUP:
+ case CUBE:
+ if (root instanceof SqlBasicCall) {
+ List<SqlNode> operandList = ((SqlBasicCall) root).getOperandList();
Review Comment:
Same as above.
##########
core/src/main/java/org/apache/calcite/sql/validate/SqlValidatorImpl.java:
##########
@@ -7378,6 +7368,37 @@ static class ExtendedExpander extends Expander {
return super.visit(literal);
}
+ /**
+ * Add all possible expandable 'group by' expression to set, which is
+ * used to check whether expr could be expanded as alias or ordinal.
+ */
+ @RequiresNonNull({"root"})
+ private void addExpandableExpressions(@UnknownInitialization
ExtendedExpander this) {
+ switch (root.getKind()) {
+ case IDENTIFIER:
+ case LITERAL:
+ aliasOrdinalExpandSet.add(root);
+ break;
+ case GROUPING_SETS:
+ case ROLLUP:
+ case CUBE:
+ if (root instanceof SqlBasicCall) {
Review Comment:
Should SqlBasicCall be replaced with SqlCall here. e.g. SqlCase does not
inherit SqlBasicCall.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
