mihaibudiu commented on PR #3929:
URL: https://github.com/apache/calcite/pull/3929#issuecomment-2364906992
@hannerwang I don't know if you have seen the comments in the JIRA.
This PR is very close to being done.
Do you think you can address the comments in time for the next release of
Calcite?
I reproduce the comments here:
> Which DB are we trying to emulate the behavior of? If so, I would like to
see a Quidem test that returns the same in Calcite and that DB, and would
return the wrong result if the bug were not fixed. Perhaps something like
select mod(empno, 3) as empno from emp group by mod(empno, 2) and make sure
that we get the right number of rows.
>
> Also I would like to see a SqlValidatorTest. Something like select
date_add('2024-01-01', empno) as empno from emp group by year(empno), where
there will be a type error (int vs date) if the wrong column is referenced.
>
> In short, more tests - that are broken before the fix, and pass after the
fix, and are demonstrably the same behavior as a given DB - will give me the
confidence to approve this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
