caicancai commented on code in PR #3956:
URL: https://github.com/apache/calcite/pull/3956#discussion_r1753019951
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1815,7 +1815,7 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
/** The {@code PI} function. */
public static final SqlFunction PI =
- SqlBasicFunction.create("PI", ReturnTypes.DOUBLE, OperandTypes.NILADIC,
+ SqlBasicFunction.create(SqlKind.PI, ReturnTypes.DOUBLE,
OperandTypes.NILADIC,
Review Comment:
Does this have to be changed to SqlKind.PI?
The others look good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
