NobiGo commented on code in PR #3956:
URL: https://github.com/apache/calcite/pull/3956#discussion_r1856173068
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlStdOperatorTable.java:
##########
@@ -1854,7 +1854,7 @@ public class SqlStdOperatorTable extends
ReflectiveSqlOperatorTable {
public static final SqlFunction PI =
SqlBasicFunction.create("PI", ReturnTypes.DOUBLE, OperandTypes.NILADIC,
SqlFunctionCategory.NUMERIC)
- .withSyntax(SqlSyntax.FUNCTION_ID);
+ .withSyntax(SqlSyntax.FUNCTION_ID_CONSTANT);
Review Comment:
This type of function is special because of the current implementation of
Calcite. In fact, this type of function requires parentheses to be called in
most databases (I haven't found any other databases yet).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
