NobiGo commented on code in PR #3945:
URL: https://github.com/apache/calcite/pull/3945#discussion_r1768951022
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -1702,6 +1703,51 @@ void testCastToBoolean(CastType castType,
SqlOperatorFixture f) {
}
}
+ @Test void testCastToDecimal() {
+ final SqlOperatorFixture f = fixture();
+ // test the minimum scale is 0
+ f.setFor(SqlStdOperatorTable.CAST, VmName.EXPAND);
+ // cast integer to decimal
+ f.checkFails("cast(123 as decimal(3, -1))",
+ "DECIMAL scale -1 must be between 0 and 19", false);
+ // cast float to decimal
+ f.checkFails("cast(12.3 as decimal(3, -1))",
+ "DECIMAL scale -1 must be between 0 and 19", false);
+ // cast decimal to decimal
+ f.checkFails("cast(cast(12.3 as decimal(3, 1)) as decimal(3, -1))",
+ "DECIMAL scale -1 must be between 0 and 19", false);
+ // cast string to decimal
+ f.checkFails("cast('12.3' as decimal(3, -1))",
+ "DECIMAL scale -1 must be between 0 and 19", false);
+ // cast interval to decimal
+ f.checkFails("cast(INTERVAL '5' hour as decimal(3, -1))",
+ "DECIMAL scale -1 must be between 0 and 19", false);
+ // test the minimum scale is -2
+ final SqlOperatorFixture negativeScaleFixture = fixture()
+ .withFactory(tf ->
+ tf.withTypeSystem(typeSystem ->
+ new RelDataTypeSystemImpl() {
+ @Override public int getMinNumericScale() {
+ return -2;
+ }
+ }));
+ // cast integer to decimal
+ negativeScaleFixture.checkScalar("cast(123 as decimal(3, -1))",
+ "120", "DECIMAL(3, -1) NOT NULL");
+ // cast float to decimal
+ negativeScaleFixture.checkScalar("cast(12.3 as decimal(3, -1))",
+ "10", "DECIMAL(3, -1) NOT NULL");
+ // cast decimal to decimal
+ negativeScaleFixture.checkScalar("cast(cast(12.3 as decimal(3, 1)) as
decimal(3, -1))",
+ "10", "DECIMAL(3, -1) NOT NULL");
+ // cast string to decimal
+ negativeScaleFixture.checkScalar("cast('12.3' as decimal(3, -1))",
+ "10", "DECIMAL(3, -1) NOT NULL");
+ // cast interval to decimal
+ negativeScaleFixture.checkScalar("cast(INTERVAL '5' hour as decimal(3,
-1))",
Review Comment:
Yes. I want to cover the INTERVAL type. But I can't find a database to
reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
