NobiGo commented on code in PR #3945:
URL: https://github.com/apache/calcite/pull/3945#discussion_r1769015795
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystem.java:
##########
@@ -62,6 +64,14 @@ public interface RelDataTypeSystem {
/** Returns the maximum precision of a NUMERIC or DECIMAL type. */
int getMaxNumericPrecision();
+ /** Returns the minimum scale of a NUMERIC or DECIMAL type. */
+ int getMinNumericScale();
Review Comment:
I checked the SQL TypeName#getMinScale and it processed the Interval type,
which returns -1 for all other types. Do we need to add this method?
##########
core/src/main/java/org/apache/calcite/rel/type/RelDataTypeSystem.java:
##########
@@ -62,6 +64,14 @@ public interface RelDataTypeSystem {
/** Returns the maximum precision of a NUMERIC or DECIMAL type. */
int getMaxNumericPrecision();
+ /** Returns the minimum scale of a NUMERIC or DECIMAL type. */
+ int getMinNumericScale();
Review Comment:
@julianhyde
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
