dssysolyatin commented on code in PR #4002:
URL: https://github.com/apache/calcite/pull/4002#discussion_r1798461050
##########
core/src/main/codegen/templates/Parser.jj:
##########
@@ -6182,6 +6182,12 @@ SqlTypeNameSpec DateTimeTypeName() :
{
return new SqlBasicTypeNameSpec(typeName, precision, s.end(this));
}
+|
Review Comment:
Regarding Babel, my initial plan was to implement DATETIME datatype parsing
at the Babel parser level, but I noticed that we have DATETIME literal parsing
for BigQuery inside Parser.jj, which is also valid for MySQL. Therefore, I
decided to put DATETIME type parsing in Parser.jj, as it would be better to
have both DATETIME datatype parsing and DATETIME literal parsing in the same
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
