mihaibudiu commented on code in PR #3177:
URL: https://github.com/apache/calcite/pull/3177#discussion_r1819429138
##########
core/src/main/java/org/apache/calcite/sql/SqlBasicFunction.java:
##########
@@ -42,7 +42,7 @@
* behavior only by providing strategy objects, not by overriding methods in a
* subclass.
*/
-public class SqlBasicFunction extends SqlFunction {
+public final class SqlBasicFunction extends SqlFunction {
Review Comment:
I agree that the intent was to have the class final, but if someone happens
to have inherited from this class in some project that uses Calcite, they will
now be stuck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
