suibianwanwank commented on code in PR #3177:
URL: https://github.com/apache/calcite/pull/3177#discussion_r1821280031
##########
core/src/main/java/org/apache/calcite/sql/SqlBasicFunction.java:
##########
@@ -42,7 +42,7 @@
* behavior only by providing strategy objects, not by overriding methods in a
* subclass.
*/
-public class SqlBasicFunction extends SqlFunction {
+public final class SqlBasicFunction extends SqlFunction {
Review Comment:
Making constructor methods private seems to be a recent change.
SqlBasicFunction was extended in the project I'm using, and this seems to be a
thing to keep in mind when upgrading calcite.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
