mihaibudiu commented on code in PR #4026:
URL: https://github.com/apache/calcite/pull/4026#discussion_r1825296129
##########
core/src/test/java/org/apache/calcite/plan/RelWriterTest.java:
##########
@@ -880,6 +880,12 @@ private static RexNode translateInput(RelJson relJson, int
input,
assertThat(result, isLinux(expected));
}
+ RexNode betweenDoubles =
Review Comment:
I suspect this will test Doubles, but are there any tests for decimal at
this point?
##########
core/src/main/java/org/apache/calcite/rel/externalize/RelJson.java:
##########
@@ -939,10 +944,21 @@ public static <C extends Comparable<C>> Range<C>
rangeFromJson(
@SuppressWarnings({"rawtypes", "unchecked"})
private static <C extends Comparable<C>> C rangeEndPointFromJson(Object o) {
Exception e = null;
+ for (Class clsType : NUMERIC_VALUE_CLASSES) {
Review Comment:
doesn't the JSON include type information so you don't have to guess?
at least for literal, it seems to include it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
