olivrlee commented on code in PR #4026:
URL: https://github.com/apache/calcite/pull/4026#discussion_r1825301846
##########
core/src/test/java/org/apache/calcite/plan/RelWriterTest.java:
##########
@@ -880,6 +880,12 @@ private static RexNode translateInput(RelJson relJson, int
input,
assertThat(result, isLinux(expected));
}
+ RexNode betweenDoubles =
Review Comment:
Hmm you're right, there's a missing case.
The existing test that has values (`14`, `20`) that test Integers will use
BigDecimal and not Double, however
a test case like
```
RexNode betweenDecimal =
rexBuilder.makeBetween(b.literal(45),
b.literal(BigDecimal.valueOf(20.0)),
b.literal(BigDecimal.valueOf(30.0)));
```
results in it using Doubles ...
Let me know if you have any ideas -- we might have to serialize the typing
when creating the JSON to avoid this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
