NobiGo commented on code in PR #4024:
URL: https://github.com/apache/calcite/pull/4024#discussion_r1823813631
##########
core/src/test/java/org/apache/calcite/test/RelMetadataTest.java:
##########
@@ -405,7 +405,8 @@ final RelMetadataFixture sql(String sql) {
.assertColumnOriginIsEmpty();
}
- @Test void testColumnOriginsUnion() {
+ @Test @Disabled("Plan contains casts, which inhibit metadata propagation")
Review Comment:
Do we need to create issue for this?
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -4395,7 +4395,7 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM (SELECT \"product_id\", \"net_weight\"\n"
+ "FROM \"foodmart\".\"product\"\n"
+ "UNION ALL\n"
- + "SELECT \"product_id\", 0 AS \"net_weight\"\n"
+ + "SELECT \"product_id\", 0E0 AS \"net_weight\"\n"
Review Comment:
This is necessary?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
