mihaibudiu commented on code in PR #4024:
URL: https://github.com/apache/calcite/pull/4024#discussion_r1826104036
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -4395,7 +4395,7 @@ private SqlDialect nonOrdinalDialect() {
+ "FROM (SELECT \"product_id\", \"net_weight\"\n"
+ "FROM \"foodmart\".\"product\"\n"
+ "UNION ALL\n"
- + "SELECT \"product_id\", 0 AS \"net_weight\"\n"
+ + "SELECT \"product_id\", 0E0 AS \"net_weight\"\n"
Review Comment:
Yes, this is necessary, since now the 0 constant is cast to the type of
net_weight, which is double.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
