suibianwanwank commented on code in PR #3994:
URL: https://github.com/apache/calcite/pull/3994#discussion_r1837625427
##########
core/src/test/java/org/apache/calcite/test/ScannableTableTest.java:
##########
@@ -278,9 +278,10 @@ public class ScannableTableTest {
final Table table = new BeatlesProjectableFilterableTable(buf, false);
final String explain = "PLAN="
+ "EnumerableAggregate(group=[{0}], C=[COUNT()])\n"
- + " EnumerableAggregate(group=[{0, 1}])\n"
- + " EnumerableInterpreter\n"
- + " BindableTableScan(table=[[s, beatles]], filters=[[=($2,
1940)]], projects=[[2, 0]])";
+ + " EnumerableCalc(expr#0=[{inputs}], expr#1=[1940], k=[$t1],
i=[$t0])\n"
Review Comment:
For the correctness of a plan, we can validate it with a test like quidem.
But for the goodness of the plan, which is a rather fuzzy concept, the plan and
the executor are often related, and the optimization of the plan usually needs
to take into account the actual execution. For example group by a, b ,can be
optimized to group by a, (if we make sure that b is constant). For the actual
execution, it may not bring significant performance improvement. But at least
for planning purposes it is concise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
