hannerwang opened a new pull request, #4050: URL: https://github.com/apache/calcite/pull/4050
### What changes were proposed in this pull request? Add Source SQL Dialect to RelToSqlConverterTest to make dialect translation more clear. ### Why are the changes needed? Currently, RelToSqlConverterTest converts the original SQL to RelNode using the default validator config and the target dialect's type system, which is confusing. We should ensure the conversion conforms to the source dialect's specifications, and then convert from the source dialect's RelNode to the target dialect's SQL. Does this PR introduce any user-facing change? Yes, the null collation the PlannerImpl use will be validator config's null collation when calcite connection property unset. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
