mihaibudiu commented on code in PR #4050:
URL: https://github.com/apache/calcite/pull/4050#discussion_r1845566105
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -559,7 +562,7 @@ private static String toSql(RelNode root, SqlDialect
dialect,
+ "FROM `foodmart`.`product`\n"
+ "GROUP BY `product_class_id`, `product_id` WITH CUBE";
sql(query).withHive().ok(expected);
- SqlDialect sqlDialect = sql(query).withHive().dialect;
+ SqlDialect sqlDialect = sql(query).withHive().targetDialect;
Review Comment:
I think this is a very useful change, the naming is indeed confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
