caicancai commented on PR #4059: URL: https://github.com/apache/calcite/pull/4059#issuecomment-2493744128
> > @ninidhiaeddine We need a unit test for this change. > > I was thinking to add a unit test for this change, but I didn't find any existing unit tests that are checking the returned `Strong.Policy` for a given `SqlOperator`. > > The only unit tests that I found to be remotely related are: `SqlOperatorTest#testPowerFun()` and `SqlOperatorTest#testPowerDecimalFunc()` which check that `POWER(2, NULL)` and `POWER(NULL, 2)` both return `NULL`. However, none of these methods make any call to `Strong.policy(arg)`. > > Any ideas on what to test here exactly? Please let me know. You can add tests in sqloperatortest -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
