mihaibudiu commented on PR #4059: URL: https://github.com/apache/calcite/pull/4059#issuecomment-2494472273
The Strong class is used during optimizations. The JavaDoc for Strong says "Utilities for strong predicates." However, POWER is not a predicate. So I don't know whether this change has any effect. It is not easy to audit all the places where Strong is used in the codebase to determine whether it will have any effect on any program. Most places I could find only simplify predicates. I don't know if this has any effect on the *_REDUCE_EXPRESSIONS set of optimization rules, where perhaps POWER with a constant null argument could be simplified to NULL at compile-time. Do you have an example which is affected by this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
