mihaibudiu commented on code in PR #4067:
URL: https://github.com/apache/calcite/pull/4067#discussion_r1861245851
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -2284,7 +2284,7 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
@LibraryOperator(libraries = {BIG_QUERY, ORACLE, POSTGRESQL})
public static final SqlFunction CHR =
SqlBasicFunction.create("CHR",
- ReturnTypes.CHAR,
+ ReturnTypes.CHAR.andThen(SqlTypeTransforms.TO_NULLABLE),
Review Comment:
I actually think that the naming of these strategies is wrong, "NULLABLE"
suggests that the return type is always NULLABLE. It should be called perhaps
NULLABLE_IF_NECESSARY.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
