dssysolyatin commented on code in PR #4067:
URL: https://github.com/apache/calcite/pull/4067#discussion_r1861270536
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -2284,7 +2284,7 @@ private static RelDataType
deriveTypeMapFromEntries(SqlOperatorBinding opBinding
@LibraryOperator(libraries = {BIG_QUERY, ORACLE, POSTGRESQL})
public static final SqlFunction CHR =
SqlBasicFunction.create("CHR",
- ReturnTypes.CHAR,
+ ReturnTypes.CHAR.andThen(SqlTypeTransforms.TO_NULLABLE),
Review Comment:
I think you are right, but probably `NULLABLE_IF_ARGS` or
`NULLABLE_IF_OPERANDS` is better.
```
There are only two hard things in Computer Science: cache invalidation and
naming things.
-- Phil Karlton
```
Lately, I've been thinking that naming is a harder than invalidation 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
