joeyutong commented on code in PR #4090:
URL: https://github.com/apache/calcite/pull/4090#discussion_r1886120552
##########
core/src/main/java/org/apache/calcite/sql/SqlKind.java:
##########
@@ -475,11 +475,11 @@ public enum SqlKind {
/** {@code NVL2} function (Oracle, Spark). */
NVL2,
- /** {@code GREATEST} function (Oracle, Spark). */
+ /** {@code GREATEST} function (Oracle). */
GREATEST,
- /** {@code GREATEST} function (PostgreSQL). */
- GREATEST_PG,
+ /** {@code GREATEST} function (PostgreSQL, Spark). */
+ GREATEST_SKIP_NULL,
Review Comment:
Revert the changes. Please take another look
##########
testkit/src/main/java/org/apache/calcite/test/SqlOperatorTest.java:
##########
@@ -11646,7 +11646,8 @@ void assertSubFunReturns(boolean binary, String s, int
start,
@Test void testGreatestFunc() {
final SqlOperatorFixture f0 =
- fixture().setFor(SqlLibraryOperators.GREATEST, VmName.EXPAND);
+ Fixtures.forOperators(true)
Review Comment:
Revert the changes. Please take another look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
