strongduanmu commented on code in PR #4108:
URL: https://github.com/apache/calcite/pull/4108#discussion_r1896223217
##########
core/src/main/java/org/apache/calcite/adapter/enumerable/RexImpTable.java:
##########
@@ -740,6 +741,7 @@ void populate1() {
defineMethod(CONCAT_WS_SPARK,
BuiltInMethod.MULTI_TYPE_STRING_ARRAY_CONCAT_WITH_SEPARATOR.method,
NullPolicy.ARG0);
+ defineMethod(ORACLE_CONVERT, BuiltInMethod.ORACLE_CONVERT.method,
NullPolicy.ARG0);
Review Comment:
What do you think about changing `ORACLE_CONVERT` to `CONVERT_ORACLE`? It
looks like the current naming format is functionName + dbType, for example:
CONCAT_WS_SPARK, BIT_COUNT_MYSQL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
