strongduanmu commented on code in PR #4108:
URL: https://github.com/apache/calcite/pull/4108#discussion_r1896225422
##########
core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java:
##########
@@ -1681,6 +1681,29 @@ public static String translateWithCharset(String s,
String transcodingName) {
}
}
+ /** Oracle's {@code CONVERT(charValue, destCharsetName[, srcCharsetName])}
function,
+ * return null if s is null or empty. */
+ public static String oracleConvert(String s, String... args) {
Review Comment:
Similar to the previous suggestion, if `oracleConvert` could be changed to
`convertOracle`, perhaps this would be consistent with the existing
`regexpReplacePg`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
