NobiGo commented on code in PR #4123:
URL: https://github.com/apache/calcite/pull/4123#discussion_r1904830495
##########
core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java:
##########
@@ -3747,6 +3747,30 @@ private SqlDialect nonOrdinalDialect() {
sql(query).dialect(mySqlDialect(NullCollation.LAST)).ok(expected);
}
+ @Test void testStarRocksCastToVarcharWithLessThanMaxPrecision() {
+ final String query = "select cast(\"product_id\" as varchar(50)),
\"product_id\" "
+ + "from \"product\" ";
+ final String expected = "SELECT CAST(`product_id` AS VARCHAR(50)),
`product_id`\n"
+ + "FROM `foodmart`.`product`";
+ sql(query).withStarRocks().ok(expected);
+ }
+
+ @Test void testStarRocksCastToVarcharWithGreaterThanMaxPrecision() {
+ final String query = "select cast(\"product_id\" as varchar(150000)),
\"product_id\" "
+ + "from \"product\" ";
+ final String expected = "SELECT CAST(`product_id` AS VARCHAR(65533)),
`product_id`\n"
Review Comment:
@mihaibudiu I noticed that our default implementation silently changes the
conversion in `SQLTypeUtil.convertTypeToSpec`, so I think there is no problem
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
