xiaochen-zhou commented on code in PR #4123:
URL: https://github.com/apache/calcite/pull/4123#discussion_r1904847552
##########
core/src/main/java/org/apache/calcite/sql/dialect/StarRocksSqlDialect.java:
##########
@@ -128,6 +153,10 @@ public StarRocksSqlDialect(Context context) {
type.getSqlTypeName(),
SqlParserPos.ZERO),
SqlParserPos.ZERO);
+ case VARCHAR:
Review Comment:
> I remember we discussed this issue before. Does StarRocks have any
restrictions on varchar types, such as varchar(65533)? If so, please explain
it, at least add JavaDoc.
There are restrictions.
<img width="355" alt="image"
src="https://github.com/user-attachments/assets/5846627e-6df0-49aa-8fd3-ea2d0266bfd0";
/>
Calcite will truncate according to the maximum precision. I have added test
cases
<img width="500" alt="image"
src="https://github.com/user-attachments/assets/3c5d69e3-cdd7-4564-a961-b11c0b6e979f";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
