mihaibudiu commented on code in PR #4160:
URL: https://github.com/apache/calcite/pull/4160#discussion_r1927418140


##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -754,6 +754,7 @@ public boolean supportsGroupByLiteral() {
 
   public boolean supportsAggregateFunction(SqlKind kind) {
     switch (kind) {
+    case LITERAL_AGG:

Review Comment:
   this change does not seem related to the jdbc adapter
   are there other aggregate functions that have to be considered for this list?
   maybe this question is not related really to the bug you are solving



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to