mihaibudiu commented on code in PR #4160:
URL: https://github.com/apache/calcite/pull/4160#discussion_r1927443066


##########
core/src/main/java/org/apache/calcite/sql/SqlDialect.java:
##########
@@ -754,6 +754,7 @@ public boolean supportsGroupByLiteral() {
 
   public boolean supportsAggregateFunction(SqlKind kind) {
     switch (kind) {
+    case LITERAL_AGG:

Review Comment:
   True, but this change will have other effects besides enabling push-down.
   But I guess this is fine. You are solving a more general problem than the 
issue states, but you have discovered through this particular issue.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to