ILuffZhe commented on code in PR #4165:
URL: https://github.com/apache/calcite/pull/4165#discussion_r1928121630
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -134,7 +134,7 @@ private SqlLibraryOperators() {
/** The "DATE_ADD(date, numDays)" function
* (Spark) Returns the date that is num_days after start_date. */
- @LibraryOperator(libraries = {SPARK})
+ @LibraryOperator(libraries = {SPARK, ORACLE, HIVE})
Review Comment:
You enable this in Oracle, do we have a test?
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -134,7 +134,7 @@ private SqlLibraryOperators() {
/** The "DATE_ADD(date, numDays)" function
* (Spark) Returns the date that is num_days after start_date. */
- @LibraryOperator(libraries = {SPARK})
+ @LibraryOperator(libraries = {SPARK, ORACLE, HIVE})
Review Comment:
Does hive support both `DATE_ADD(date, interval)` and `DATE_ADD(date,
numDays)`?
##########
site/_docs/reference.md:
##########
@@ -2780,7 +2780,7 @@ In the following:
| m | expr1 <=> expr2 | Whether two values are
equal, treating null values as the same, and it's similar to `IS NOT DISTINCT
FROM`
| p | ACOSD(numeric) | Returns the inverse
cosine of *numeric* in degrees as a double. Returns NaN if *numeric* is NaN.
Fails if *numeric* is less than -1.0 or greater than 1.0.
| * | ACOSH(numeric) | Returns the inverse
hyperbolic cosine of *numeric*
-| o s | ADD_MONTHS(date, numMonths) | Returns the date that
is *numMonths* after *date*
+| o s h | ADD_MONTHS(date, numMonths) | Returns the date that
is *numMonths* after *date*
Review Comment:
This function seems not being added above, please take a look and also make
sure the reference's changing consistent with what in SqlLibraryOpetators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
