ILuffZhe commented on code in PR #4165:
URL: https://github.com/apache/calcite/pull/4165#discussion_r1929449604
##########
core/src/main/java/org/apache/calcite/sql/fun/SqlLibraryOperators.java:
##########
@@ -162,7 +162,7 @@ private SqlLibraryOperators() {
* <p>MySQL has "DATEDIFF(date, date2)" and "TIMEDIFF(time, time2)" functions
* but Calcite does not implement these because they have no "timeUnit"
* argument. */
- @LibraryOperator(libraries = {MSSQL, REDSHIFT, SNOWFLAKE})
+ @LibraryOperator(libraries = {MSSQL, REDSHIFT, SNOWFLAKE, HIVE})
Review Comment:
testDateDiff() and testDateSub()
##########
site/_docs/reference.md:
##########
@@ -2888,7 +2888,7 @@ In the following:
| b | FORMAT_TIME(string, time) | Formats *time*
according to the specified format *string*
| b | FORMAT_TIMESTAMP(string timestamp) | Formats *timestamp*
according to the specified format *string*
| s | GETBIT(value, position) | Equivalent to
`BIT_GET(value, position)`
-| b o p r s | GREATEST(expr [, expr ]*) | Returns the greatest of
the expressions
+| b o p r s h | GREATEST(expr [, expr ]*) | Returns the greatest of
the expressions
Review Comment:
so is testGreatestFunc()
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
