xuzifu666 commented on PR #4165: URL: https://github.com/apache/calcite/pull/4165#issuecomment-2613997498
> Hi @xuzifu666 , you don't need to force-push every time, which makes it not easier to review. In this case, make sure all the functions enabled in Hive library is document in reference.md, and SqlOperatorTest should also cover those functions (the last commit still missed some tests). Please take a look and cc me when you are ready. > > By the way, I think it might be better to add a new JIRA ticket, [CALCITE-6241](https://issues.apache.org/jira/browse/CALCITE-6241) is for Spark library. Very thanks for your remind, I had add all changes in doc and add all cases in Test, PTAL when you free time. @ILuffZhe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
