ILuffZhe commented on PR #4165: URL: https://github.com/apache/calcite/pull/4165#issuecomment-2623345933
> > > > It seems your changes in PR is not consistent with what described in JIRA. > > > > > > > > > This pr is aim to enable some existing functions to Hive library, I had changed purpose about it. Would you give some advice if it is not fitable. Thanks~ @ILuffZhe > > > > > > This case should only enable existing functions which have the same behavior in Hive. > > If not, maybe we should file a new JIRA ticket and implement it if you want. > > This case is only enable existing functions which have the same behavior in Hive，not implement for new functions，so keep it can be fine without file a new jira ticket or can merge this pr firstly? @ILuffZhe Sorry for the delay, been a little busy these days. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
