rubenada commented on code in PR #4181:
URL: https://github.com/apache/calcite/pull/4181#discussion_r1948713704
##########
core/src/main/java/org/apache/calcite/sql2rel/RelDecorrelator.java:
##########
@@ -795,6 +801,146 @@ private static void shiftMapping(Map<Integer, Integer>
mapping, int startIndex,
return null;
}
+ private @Nullable Frame decorrelateFetchOneSort(Sort sort, final Frame
frame) {
Review Comment:
It may be a cleaner solution, but IMO maybe a bit overkill for this
particular purpose. I think protected methods would suffice to provide a way to
"fallback". Let's see if there are other opinions on this subject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
